Date() support added for setTime, getTimeAsDate added #53

Merged
merged 1 commit into from Nov 24, 2012

Conversation

Projects
None yet
2 participants

AAverin commented Nov 21, 2012

setTime can now have Date() object as an argument
getTimeAsDate method was added to retrieve time as date
inst.minuts renamed to inst.minutes

and btw, why not use underlying Date object to store all of the time settings?

setTime now can have Date() object as an argument
getTimeAsDate method was added to retrieve time as date
inst.minuts renamed to inst.minutes
Owner

fgelinas commented Nov 21, 2012

Thanks for the pull request, I'll check it later.
For the Date object question, at first I did not think of it and if I was to write the plugin again, I would use it.
But using the Date object has some limitations too like when only minutes or hours are selected. Also the timepicker is not limited to valid minutes / hours so one can set options to enter minutes ranging from 1 to 100.

fgelinas added a commit that referenced this pull request Nov 24, 2012

Merge pull request #53 from AAverin/master
Date() support added for setTime, getTimeAsDate added

@fgelinas fgelinas merged commit 5fbb73c into fgelinas:master Nov 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment