jquery 1.9+ compatibility update #60

Merged
merged 1 commit into from Jan 25, 2013

Conversation

Projects
None yet
3 participants
Contributor

marksulls commented Jan 24, 2013

$.browser.msie no longer exists in jquery 1.9+. see http://api.jquery.com/jQuery.browser/

There might be more to change or a better way to do this, but this works if you are interested

fix for jquery 1.9+
$.browser.msie no longer exists in jquery 1.9+. see http://api.jquery.com/jQuery.browser/

Thank you Mark,
I'll merge this as it seems correct.

Owner

fgelinas commented Jan 25, 2013

Thank you Mark,

fgelinas added a commit that referenced this pull request Jan 25, 2013

Merge pull request #60 from marksulls/master
jquery 1.9+ compatibility update

@fgelinas fgelinas merged commit a3e9bc1 into fgelinas:master Jan 25, 2013

This doesn't fix the problem, as $.browser has been removed completely from jQuery 1.9. Since jQuery UI has dropped support for IE 6, I would expect it to be safe to just delete this block of code altogether.

Contributor

marksulls replied Jan 26, 2013

yep, didn't really test that whole thing, just enough for what i needed. I will fix it correctly and submit another pull request just in case you want to keep the ie6 support.

Owner

fgelinas replied Jan 26, 2013

I agree that this code should be removed completly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment