Fix autoquoting of and/or/xor keywords before => #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser was incorrectly treating 'and', 'or', and 'xor' as list terminators even when they appeared before '=>' in hash literals. This caused syntax errors in valid Perl code like: my %h = ( and => 1, or => 2, xor => 3 ); The fix adds special handling in: 1. ListParser.isListTerminator() - checks if and/or/xor are followed by '=>' and if so, doesn't treat them as terminators 2. ParsePrimary.parseOperator() - handles autoquoting when these keywords appear as OPERATOR tokens before '=>' 3. ParsePrimary.parseIdentifier() - already handled autoquoting for IDENTIFIER tokens (unchanged) This allows these keywords to be used as hash keys with fat comma syntax while still functioning as operators in other contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser was incorrectly treating 'and', 'or', and 'xor' as list terminators even when they appeared before '=>' in hash literals. This caused syntax errors in valid Perl code like:
my %h = ( and => 1, or => 2, xor => 3 );
The fix adds special handling in:
This allows these keywords to be used as hash keys with fat comma syntax while still functioning as operators in other contexts.