Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

jQuery stop() not working? #139

Closed
n8felton opened this Issue · 3 comments

2 participants

@n8felton

It appears that a recent commit may have broke the stop() function?

Basic test: http://jsfiddle.net/n8felton/MJZJa/

@fgnass
Owner

Hm, there has never been such a method in the official spin.js plugin, only in the Spinner object. To stop a spinner via jQuery you have to call $('#el').spin(false).

@fgnass fgnass closed this
@n8felton

On your primary site, it states:

Hiding the spinner

To hide the spinner, invoke the stop() method, which removes the UI elements from the DOM and stops the animation. Stopped spinners may be reused by calling spin() again.

This may just be a regular function, not necessarily a jQuery function. Regardless, it was working with test code yesterday, and now the stop() function appears to not work anymore. I will use the method you described however, as that appears to work.

@fgnass
Owner

Strange, maybe you were using a 3rd party plugin? The official one only exists since yesterday and hasn't changed since the first commit: https://github.com/fgnass/spin.js/commits/gh-pages/jquery.spin.js

BTW, you can invoke the underlying stop() method like this:

$('#test').data('spinner').stop();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.