IE9 error possibly due to opacity #31

Closed
weerd482 opened this Issue Sep 16, 2011 · 3 comments

Projects

None yet

4 participants

@weerd482

There seems to be an error that gets thrown in IE9 when loading the spinner. I think it may be related to the opacity changes, possibly with how IE9 does the opacity effects.

If you load http://fgnass.github.com/spin.js/ in IE9 you should be able to see the error and associated pop up that shows up.

@fgnass
Owner
fgnass commented Sep 17, 2011

Could you please post a screenshot? I've opened the page in two different IE9s as well as on browserstack and didn't see any errors.

@arjes
arjes commented Sep 30, 2011

I can confirm I am getting an opacity error as well. The error is on this line:
el.firstChild.childNodes[i+o].firstChild.firstChild.opacity = val;
and IE only says "Object Required". I'm going to see if i I can debug it and I'll report back if I find anything. The link provided earlier didn't generate the error for me either.

EDIT: Debugging in IE blows, but the issue is that el has no children. I'm not sure what element el is, but the same code works in FF

@nverwer
nverwer commented Oct 3, 2011

I run into the same issue. Just before the spinner disappears, when I load different content in a div, there is a problem in line 211:

el.childNodes[i].style.opacity = val;

The problem is that el.childNodes is empty.
I can see two possibilities here:

  1. Remove the spinner before I load different content in the div.
  2. Add this just before line 211: if (i < el.childNodes.length)

Maybe it would be safe to incorporate this in spin.js?

@fgnass fgnass closed this in 8574d16 Oct 5, 2011
@fgnass fgnass added a commit that closed this issue Oct 5, 2011
@fgnass Merge branch 'master' into gh-pages
* master:
  Added a sanity check. Should fix #31
0737ee3
@fgnass fgnass closed this in 0737ee3 Oct 5, 2011
@fgnass fgnass closed this in 8e509f0 Oct 5, 2011
@fgnass fgnass added a commit that closed this issue Oct 5, 2011
@fgnass Merge branch 'master' into gh-pages
* master:
  Added some sanity checks. Should fix #31
feccab5
@fgnass fgnass closed this in feccab5 Oct 5, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment