Spin does not appear with Modernizr (html5shiv) #58

Closed
Takazudo opened this Issue Mar 14, 2012 · 5 comments

Projects

None yet

5 participants

@Takazudo

Hi, I love spin.js.

I used spin.js in my project and found that it has trouble with Modernizr.
http://www.modernizr.com/download/

When I use spin.js with Modernizr's html5shiv v3.4, spin did not appear on IE8 at all.
Without html5shiv, it had no trouble.

This seems a problem about html5shiv; but this seems a common pitfall for many people; so I just wanted tell you this.

@kristerkari

I can also confirm that this is happening for IE6, IE7 and IE8.

Spin.js does not work with html5shiv 3.4, but works fine without it.

@fgnass fgnass closed this in f5f95d8 Mar 21, 2012
@kristerkari

Nice to see this get fixed, thanks!

@Takazudo

cool ;)

@CBung
CBung commented Mar 21, 2012

I love the net some days. Found your plugin after seeing it in the credits of some HTML5 photoshop clone, wanted to use it on a new project that I have to demo tomorrow and found this bug in the wee hours last night. Was disappointed and then mere hours later its fixed already, pretty lucky for me :) Thanks!

@rexcfnghk

I am using Modernizr 2.6.2 and the issue still exists for IE8. I am using spin.js 1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment