New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin does not appear with Modernizr (html5shiv) #58

Closed
Takazudo opened this Issue Mar 14, 2012 · 5 comments

Comments

Projects
None yet
5 participants
@Takazudo

Takazudo commented Mar 14, 2012

Hi, I love spin.js.

I used spin.js in my project and found that it has trouble with Modernizr.
http://www.modernizr.com/download/

When I use spin.js with Modernizr's html5shiv v3.4, spin did not appear on IE8 at all.
Without html5shiv, it had no trouble.

This seems a problem about html5shiv; but this seems a common pitfall for many people; so I just wanted tell you this.

@kristerkari

This comment has been minimized.

Show comment
Hide comment
@kristerkari

kristerkari Mar 15, 2012

I can also confirm that this is happening for IE6, IE7 and IE8.

Spin.js does not work with html5shiv 3.4, but works fine without it.

kristerkari commented Mar 15, 2012

I can also confirm that this is happening for IE6, IE7 and IE8.

Spin.js does not work with html5shiv 3.4, but works fine without it.

@kristerkari

This comment has been minimized.

Show comment
Hide comment
@kristerkari

kristerkari Mar 21, 2012

Nice to see this get fixed, thanks!

kristerkari commented Mar 21, 2012

Nice to see this get fixed, thanks!

@Takazudo

This comment has been minimized.

Show comment
Hide comment
@Takazudo

Takazudo commented Mar 21, 2012

cool ;)

@bung

This comment has been minimized.

Show comment
Hide comment
@bung

bung Mar 21, 2012

I love the net some days. Found your plugin after seeing it in the credits of some HTML5 photoshop clone, wanted to use it on a new project that I have to demo tomorrow and found this bug in the wee hours last night. Was disappointed and then mere hours later its fixed already, pretty lucky for me :) Thanks!

bung commented Mar 21, 2012

I love the net some days. Found your plugin after seeing it in the credits of some HTML5 photoshop clone, wanted to use it on a new project that I have to demo tomorrow and found this bug in the wee hours last night. Was disappointed and then mere hours later its fixed already, pretty lucky for me :) Thanks!

@rexcfnghk

This comment has been minimized.

Show comment
Hide comment
@rexcfnghk

rexcfnghk Aug 27, 2013

I am using Modernizr 2.6.2 and the issue still exists for IE8. I am using spin.js 1.3.2

rexcfnghk commented Aug 27, 2013

I am using Modernizr 2.6.2 and the issue still exists for IE8. I am using spin.js 1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment