New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UMD Shim to be resilient to HTMLElement global pollution #300

Merged
merged 1 commit into from Jul 22, 2015

Conversation

Projects
None yet
3 participants
@mikesherov
Contributor

mikesherov commented Jul 21, 2015

Please see https://github.com/umdjs/umd/pull/63/files and umdjs/umd#35 for more information, but
this change prevents an HTML element with an id of module from cuasing the UMD shim to incorrectly detect the enivornment as node.

Update UMD Shim to be resilient to HTMLElement global pollution
Please see https://github.com/umdjs/umd/pull/63/files and umdjs/umd#35 for more information, but
this change prevents an HTML element with an id of `module` from cuasing the UMD shim to incorrectly detect the enivornment as node.

fgnass added a commit that referenced this pull request Jul 22, 2015

Merge pull request #300 from mikesherov/patch-1
Update UMD Shim to be resilient to HTMLElement global pollution

@fgnass fgnass merged commit 77851f0 into fgnass:master Jul 22, 2015

@fgnass

This comment has been minimized.

Show comment
Hide comment
@fgnass

fgnass Jul 22, 2015

Owner

I'm currently not near any computer (and won't be so for the next week) but maybe @TimothyGu can cut a new release?

Owner

fgnass commented Jul 22, 2015

I'm currently not near any computer (and won't be so for the next week) but maybe @TimothyGu can cut a new release?

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Jul 22, 2015

Contributor

That would be fantastic! I appreciate the quick movement here.

Contributor

mikesherov commented Jul 22, 2015

That would be fantastic! I appreciate the quick movement here.

@TimothyGu

This comment has been minimized.

Show comment
Hide comment
@TimothyGu

TimothyGu Jul 24, 2015

Collaborator

@mikesherov, done. Sorry about the wait.

Collaborator

TimothyGu commented Jul 24, 2015

@mikesherov, done. Sorry about the wait.

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Jul 24, 2015

Contributor

No worries! Thanks for the bump and helping out!

Contributor

mikesherov commented Jul 24, 2015

No worries! Thanks for the bump and helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment