Update UMD Shim to be resilient to HTMLElement global pollution #300

Merged
merged 1 commit into from Jul 22, 2015

Projects

None yet

3 participants

@mikesherov
Contributor

Please see https://github.com/umdjs/umd/pull/63/files and umdjs/umd#35 for more information, but
this change prevents an HTML element with an id of module from cuasing the UMD shim to incorrectly detect the enivornment as node.

@mikesherov mikesherov Update UMD Shim to be resilient to HTMLElement global pollution
Please see https://github.com/umdjs/umd/pull/63/files and umdjs/umd#35 for more information, but
this change prevents an HTML element with an id of `module` from cuasing the UMD shim to incorrectly detect the enivornment as node.
ee43339
@fgnass fgnass merged commit 77851f0 into fgnass:master Jul 22, 2015
@fgnass
Owner
fgnass commented Jul 22, 2015

I'm currently not near any computer (and won't be so for the next week) but maybe @TimothyGu can cut a new release?

@mikesherov
Contributor

That would be fantastic! I appreciate the quick movement here.

@TimothyGu
Collaborator

@mikesherov, done. Sorry about the wait.

@mikesherov
Contributor

No worries! Thanks for the bump and helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment