This repository has been archived by the owner. It is now read-only.

HEADS UP! Bindler might break on Vagrant 1.4 #26

Closed
fgrehm opened this Issue Dec 4, 2013 · 8 comments

Comments

Projects
None yet
4 participants
@fgrehm
Owner

fgrehm commented Dec 4, 2013

I suspect this change might break things over here

/cc @patcon @ipwnstuff

@mitchellh

This comment has been minimized.

Show comment
Hide comment
@mitchellh

mitchellh Dec 4, 2013

Since bindler is so dependent on some internal Vagrant state, I recommend putting this sort of check in the plugin.rb file:

if Vagrant::VERSION >= "1.4.0"
    puts "NOPE"
end

Sort of thing.

mitchellh commented Dec 4, 2013

Since bindler is so dependent on some internal Vagrant state, I recommend putting this sort of check in the plugin.rb file:

if Vagrant::VERSION >= "1.4.0"
    puts "NOPE"
end

Sort of thing.

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Dec 4, 2013

Owner

@mitchellh You beat me :P I was just spreading the word and was about to mention that over here. We really need to add a check for compatible vagrant versions over here to prevent that kind of stuff :)

Owner

fgrehm commented Dec 4, 2013

@mitchellh You beat me :P I was just spreading the word and was about to mention that over here. We really need to add a check for compatible vagrant versions over here to prevent that kind of stuff :)

@erran

This comment has been minimized.

Show comment
Hide comment
@erran

erran Dec 4, 2013

Collaborator

I think it's handled well in vagrant-berkshelf see the install action they've defined. If you agree I'm up for creating a PR.

Collaborator

erran commented Dec 4, 2013

I think it's handled well in vagrant-berkshelf see the install action they've defined. If you agree I'm up for creating a PR.

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Dec 5, 2013

Owner

@ipwnstuff 👍 be my guest 😃

Owner

fgrehm commented Dec 5, 2013

@ipwnstuff 👍 be my guest 😃

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Jan 27, 2014

Owner

According to @rogeriopradoj on GH-29 the plugin is really broken, let's close this issue :-)

Owner

fgrehm commented Jan 27, 2014

According to @rogeriopradoj on GH-29 the plugin is really broken, let's close this issue :-)

@fgrehm fgrehm closed this Jan 27, 2014

@rogeriopradoj

This comment has been minimized.

Show comment
Hide comment
@rogeriopradoj

rogeriopradoj Jan 27, 2014

Hello, @fgrehm , trick question: are you using Bindler in your current setup? If positive, which versions (Vagrant, Os, provider etc.)?

;-)

rogeriopradoj commented Jan 27, 2014

Hello, @fgrehm , trick question: are you using Bindler in your current setup? If positive, which versions (Vagrant, Os, provider etc.)?

;-)

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Jan 27, 2014

Owner

Not really, as I said on other issues I'm no longer using it and I'm stepping out of it for a while (but @erran and @patcon are both collaborators ;)

Owner

fgrehm commented Jan 27, 2014

Not really, as I said on other issues I'm no longer using it and I'm stepping out of it for a while (but @erran and @patcon are both collaborators ;)

@rogeriopradoj

This comment has been minimized.

Show comment
Hide comment
@rogeriopradoj

rogeriopradoj Jan 27, 2014

;-) . Firstly, congrats for your work around Vagrant ecosystem, and for gaining commit permission in official repo because of your great job. I really hope to meet you in person someday (maybe at Campus Party)?

See ya!

rogeriopradoj commented Jan 27, 2014

;-) . Firstly, congrats for your work around Vagrant ecosystem, and for gaining commit permission in official repo because of your great job. I really hope to meet you in person someday (maybe at Campus Party)?

See ya!

erran added a commit that referenced this issue Jan 27, 2014

Merge pull request #27 from erran/vagrant-version-check
Add Vagrant version constraints and checks (Fixes #26)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.