New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New collaborators wanted! #10

Closed
fgrehm opened this Issue Jun 9, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@fgrehm
Owner

fgrehm commented Jun 9, 2013

Unfortunately I haven't had enough time to catch up on features since the initial public release and given that quite a few people liked the idea I'm up for giving commit access to those interested on pushing the development further. A while ago I came across this issue on rspec-spies which led me to The Pull Request Hack and it seems like an awesome idea. Even though the plugin is on its really early days I'm gonna try it here.

On its current state, the plugin fulfills my current needs but there is a lot of room for improvements, as I said before the current codebase came out of lots of spiking and is lacking some love. So if you are interested in contributing please keep that in mind and refactor things as you go ;-)

I'm not sure what is the best workflow for everyone but I suggest feature branches and pull requests for discussion as a start and work out from there rather than just going off master. There is also the matter of the gem pushing, so if you can let me know rubygems logins or email accounts, I can add there.

@patcon was the first and only one so far to submit a PR, so welcome aboard 🎆. @oker1 @cromulus @maljub01, you guys have shown some interest on the plugin, so feel free to submit a PR and join the project :-)

@patcon

This comment has been minimized.

Show comment
Hide comment
@patcon

patcon Jun 10, 2013

Collaborator

Oh my god! Fireworks! I give full credit to my drunk-tweet for kindling your faith in me

But seriously -- great idea. I really like this approach. I'm "patcon" on rubygems.org if you're ok with that.

As an addendum, I'd suggest that we solicit a seconding on new gem releases by opening a PR with only the version-bump changes. Just one or two 👍s or acknowledgements would make me feel more comfortable. I only suggest that as a way to address this concern in the HackerNews thread discussing that Pull Request Hack article.

EDIT: Or maybe that last suggestion is overkill. Vetoes welcome!

Collaborator

patcon commented Jun 10, 2013

Oh my god! Fireworks! I give full credit to my drunk-tweet for kindling your faith in me

But seriously -- great idea. I really like this approach. I'm "patcon" on rubygems.org if you're ok with that.

As an addendum, I'd suggest that we solicit a seconding on new gem releases by opening a PR with only the version-bump changes. Just one or two 👍s or acknowledgements would make me feel more comfortable. I only suggest that as a way to address this concern in the HackerNews thread discussing that Pull Request Hack article.

EDIT: Or maybe that last suggestion is overkill. Vetoes welcome!

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Jun 10, 2013

Owner

@patcon 👍 on PR for version bump changes

Owner

fgrehm commented Jun 10, 2013

@patcon 👍 on PR for version bump changes

@oker1

This comment has been minimized.

Show comment
Hide comment
@oker1

oker1 Jun 10, 2013

Great idea! I'll try to debug my issue :)

oker1 commented Jun 10, 2013

Great idea! I'll try to debug my issue :)

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Dec 13, 2013

Owner

Alright, we have enough collaborators already. If someone eventually submits a substantial PR I'll be more than happy to bring he / she aboard :-)

Owner

fgrehm commented Dec 13, 2013

Alright, we have enough collaborators already. If someone eventually submits a substantial PR I'll be more than happy to bring he / she aboard :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment