Skip to content
This repository has been archived by the owner. It is now read-only.

add default encoding when reading json #5

Merged
merged 1 commit into from Dec 3, 2013
Merged

Conversation

@ryuzee
Copy link
Collaborator

@ryuzee ryuzee commented Nov 17, 2013

When Vagrantfile is placed at the directory which includes Multibyte path name, this plugin can not parse json and raise exception as follows.

STDERR: /opt/vagrant/embedded/lib/ruby/1.9.1/json/common.rb:148:in `encode': "\xE3" on US-ASCII
(Encoding::InvalidByteSequenceError)

fgrehm added a commit that referenced this pull request Dec 3, 2013
add default encoding when reading json
@fgrehm fgrehm merged commit 9d88c4c into fgrehm:master Dec 3, 2013
@fgrehm
Copy link
Owner

@fgrehm fgrehm commented Dec 3, 2013

@ryuzee sorry I missed out this PR and the other one =/ thanks for contributing :)

So I haven't been using this plugin as much as I expected. I hardly fire up a vagrant vms different than vagrant-lxc ones these days and a plain old lxc-list gives me enough information right now.
You seem to be interested enough on it to care to submit 2 pull requests, would you like to become a project maintainer? 😃

@ryuzee
Copy link
Collaborator Author

@ryuzee ryuzee commented Dec 3, 2013

@fgrehm

Hi, thanks for your comment and merging it.
I'm constantly using this plugin. If you do not mind I would like to be a project maintainer :-)

@fgrehm
Copy link
Owner

@fgrehm fgrehm commented Dec 13, 2013

@ryuzee there you go! you now have superpowers 🎆

feel free to improve the plugin as wanted and please LMK when you have a need to push it to rubygems so I can add you there too ;-) for now I'll be keeping an eye on things and feel free to ping me in case you need any help reviewing code or testing.

have fun 😃

@ryuzee
Copy link
Collaborator Author

@ryuzee ryuzee commented Dec 13, 2013

Thanks for everything @fgrehm

I'm very happy to contribute to this useful plugin. If you do not ming, please add me the priviledge of posting this plugin to rubygems.
Thanks again!

@ryuzee ryuzee deleted the ryuzee:json_read_issue branch Dec 14, 2013
@fgrehm
Copy link
Owner

@fgrehm fgrehm commented Dec 17, 2013

@ryuzee There you go! You now have permissions to publish to rubygems!

My recommendations are just for you to please keep the CHANGELOG up to date and try to follow semver when cutting new releases ;-) Have fun!

@ryuzee
Copy link
Collaborator Author

@ryuzee ryuzee commented Dec 17, 2013

@fgrehm Thanks for your effort!! I've just understood I need to update CHANGELOG when releasing new versions. Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.