New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for public networks #119

Closed
fgrehm opened this Issue Jul 29, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@cwoac

This comment has been minimized.

Show comment
Hide comment
@cwoac

cwoac Sep 23, 2013

Contributor

So, I was/am thinking about doing a patch for this; As I see it, the problem is basically one of choosing / setting the correct bridge target in the config file for the vagrant.
Currently this is (in the configs) hard coded to lxcbr0; I'm trying to think what would be the most vagrant-y way of doing it. The (simplest) way would be to pick another default (lxcbr1? br0?) and have it override/handle the network "public_network" config option with a function that mangles the lxc.conf.

It would be nice if these could be specified by the user in a config variable, but I'm not sure if that would be appropriate / feasible.

This won't do anything special for wireless users, but it should be a decent start.

What do you think?

Contributor

cwoac commented Sep 23, 2013

So, I was/am thinking about doing a patch for this; As I see it, the problem is basically one of choosing / setting the correct bridge target in the config file for the vagrant.
Currently this is (in the configs) hard coded to lxcbr0; I'm trying to think what would be the most vagrant-y way of doing it. The (simplest) way would be to pick another default (lxcbr1? br0?) and have it override/handle the network "public_network" config option with a function that mangles the lxc.conf.

It would be nice if these could be specified by the user in a config variable, but I'm not sure if that would be appropriate / feasible.

This won't do anything special for wireless users, but it should be a decent start.

What do you think?

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm Sep 27, 2013

Owner

@cwoac as I said on other issues my networking skills are close to zero and I need to think about it. I've gotta fix some bugs related to 0.6.0 and will get back to networking after that :)

Owner

fgrehm commented Sep 27, 2013

@cwoac as I said on other issues my networking skills are close to zero and I need to think about it. I've gotta fix some bugs related to 0.6.0 and will get back to networking after that :)

@fgrehm

This comment has been minimized.

Show comment
Hide comment
@fgrehm

fgrehm May 11, 2014

Owner

Closing as it is not a feature that has had enough interest (private networks have a higher priority ATM), I'd look into a PR though.

Owner

fgrehm commented May 11, 2014

Closing as it is not a feature that has had enough interest (private networks have a higher priority ATM), I'd look into a PR though.

@fgrehm fgrehm closed this May 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment