Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening a new file keeps the old one #16

Open
hugoledoux opened this issue Aug 21, 2019 · 4 comments
Open

opening a new file keeps the old one #16

hugoledoux opened this issue Aug 21, 2019 · 4 comments

Comments

@hugoledoux
Copy link
Contributor

but since you modify coordinates then it gets messy, see below.

Probably simpler to just flush the old model and always keep one and one, no?
2019-08-21 at 14 14

@fdahle
Copy link

fdahle commented Sep 19, 2019

Originally this function is intentionally designed like this. The case could be that the user have splitted files, for example a houses.json and a streets.json.

Should I therefore keep this feature or put it out?

@hugoledoux
Copy link
Contributor Author

hugoledoux commented Sep 19, 2019

OK yeah it's nice, let's keep it.

But there seems to be something a bit wrong. I splitted Den Haag from https://www.cityjson.org/datasets/ into terrain.json and buidlings.json, and when I open them both the terrain is "higher", see:
2019-09-19 at 16 11

If I open them in azul, all is good.

Possible that it works if both have the same bbox since you rescale? If the case then in practice it's nearly impossible to have, and then I'd drop the feature. If fixable then I'd keep it.

@hugoledoux
Copy link
Contributor Author

also, if you pick say 3 buildings from a dataset and put them in a different dataset then open both, you can this (scaling issues):

2019-09-19 at 16 23

@fdahle
Copy link

fdahle commented Sep 22, 2019

I'm currently investigating to not normalize the coordinates, as so the relation of the objects (also from different files) should be kept.
The current status is that it works - but I still have some problems with the camera and the light, as the whole scene is shifted vertically
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants