Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserving the 'id' attribute in resource upon persistence. #20

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@daya
Copy link

daya commented Oct 25, 2019

This change will bring consistency with fhirbase load functionality which preserves the id attribute in resource

Daya Sharma
This change will bring consistency with `fhirbase load` functionality which preserves the `id` attribute
@daya

This comment has been minimized.

Copy link
Author

daya commented Oct 25, 2019

This refers to issue #19

@daya

This comment has been minimized.

Copy link
Author

daya commented Oct 27, 2019

This is apparently failing for reasons not related to the change

Failed to create GitHub release page: failed to get release: get release tag: invalid status: 401 Unauthorized: GET https://api.github.com/repos/fhirbase/fhirbase/releases/tags/nightly-build: 401 Bad credentials

@daya

This comment has been minimized.

Copy link
Author

daya commented Oct 27, 2019

@mlapshin @niquola any ideas on how to proceed from here?

@mlapshin mlapshin merged commit 900d7c9 into fhirbase:master Nov 11, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@mlapshin

This comment has been minimized.

Copy link
Contributor

mlapshin commented Nov 11, 2019

@daya Thanks for your contribution and sorry for long approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.