Skip to content

Add a version label #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

Add a version label #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80c7fc
Add a version label to the spilo pods (which might break / complicate…
eberlep Oct 24, 2025
b3abeb5
Add comment
eberlep Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/v1/postgres_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ const (
StandbyMethod = "streaming_host"
// PartitionIDLabelName Name of the managed-by label
PartitionIDLabelName string = "postgres.database.fits.cloud/partition-id"
// PostgresVersionLabelName Name of the version label
PostgresVersionLabelName string = "postgres.database.fits.cloud/version"

ApplicationLabelName = "application"
ApplicationLabelValue = "spilo"
Expand Down Expand Up @@ -679,6 +681,8 @@ func (p *Postgres) ToUnstructuredZalandoPostgresql(z *zalando.Postgresql, c *cor
// Add the newly introduced label only here, not in p.ToZalandoPostgresqlMatchingLabels() (so that the selectors using p.ToZalandoPostgresqlMatchingLabels() will still work until all postgres resources have that new label)
// TODO once all the custom resources have that new label, move this part to p.ToZalandoPostgresqlMatchingLabels()
z.Labels[PartitionIDLabelName] = p.Spec.PartitionID
// Add the additional version label to the custom resource
z.Labels[PostgresVersionLabelName] = p.Spec.Version

if image != "" {
z.Spec.DockerImage = image
Expand Down
1 change: 1 addition & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,7 @@ func main() {
pgParamBlockList[blockedParam] = true
}

// be careful changing this value if you also set the pg.PostgresVersionLabelName inherited_label
viper.SetDefault(majorVersionUpgradeModeFlg, "manual")
majorVersionUpgradeMode = viper.GetString(majorVersionUpgradeModeFlg)

Expand Down
2 changes: 1 addition & 1 deletion pkg/operatormanager/operatormanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ func (m *OperatorManager) editConfigMap(cm *corev1.ConfigMap, namespace string,
// set the reference to our custom pod environment secret
cm.Data["pod_environment_secret"] = PodEnvSecretName
// set the list of inherited labels that will be passed on to the pods
s := []string{pg.TenantLabelName, pg.ProjectIDLabelName, pg.UIDLabelName, pg.NameLabelName, pg.PartitionIDLabelName}
s := []string{pg.TenantLabelName, pg.ProjectIDLabelName, pg.UIDLabelName, pg.NameLabelName, pg.PartitionIDLabelName, pg.PostgresVersionLabelName}
// TODO maybe use a precompiled string here
cm.Data["inherited_labels"] = strings.Join(s, ",")

Expand Down
Loading