Skip to content

Commit

Permalink
Override initialize() instead of __init__() in RequestHandler subclas…
Browse files Browse the repository at this point in the history
…ses.

This is a slight simplification and makes it easier to create further
application-specific subclasses.

Closes tornadoweb#191.
  • Loading branch information
bdarnell committed Dec 13, 2010
1 parent cce8218 commit 2675142
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions tornado/web.py
Expand Up @@ -1201,8 +1201,7 @@ def __str__(self):

class ErrorHandler(RequestHandler):
"""Generates an error response with status_code for all requests."""
def __init__(self, application, request, status_code):
RequestHandler.__init__(self, application, request)
def initialize(self, status_code):
self.set_status(status_code)

def prepare(self):
Expand All @@ -1218,8 +1217,7 @@ class RedirectHandler(RequestHandler):
(r"/oldpath", web.RedirectHandler, {"url": "/newpath"}),
])
"""
def __init__(self, application, request, url, permanent=True):
RequestHandler.__init__(self, application, request)
def initialize(self, url, permanent=True):
self._url = url
self._permanent = permanent

Expand All @@ -1245,8 +1243,7 @@ class StaticFileHandler(RequestHandler):
want browsers to cache a file indefinitely, send them to, e.g.,
/static/images/myimage.png?v=xxx.
"""
def __init__(self, application, request, path, default_filename=None):
RequestHandler.__init__(self, application, request)
def initialize(self, path, default_filename=None):
self.root = os.path.abspath(path) + os.path.sep
self.default_filename = default_filename

Expand Down Expand Up @@ -1327,8 +1324,7 @@ class FallbackHandler(RequestHandler):
(r".*", FallbackHandler, dict(fallback=wsgi_app),
])
"""
def __init__(self, app, request, fallback):
RequestHandler.__init__(self, app, request)
def initialize(self, fallback):
self.fallback = fallback

def prepare(self):
Expand Down

0 comments on commit 2675142

Please sign in to comment.