Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QSetting to the AddressBook #313

Closed
hsequeda opened this issue Jan 13, 2020 · 1 comment · Fixed by #314
Closed

Add QSetting to the AddressBook #313

hsequeda opened this issue Jan 13, 2020 · 1 comment · Fixed by #314

Comments

@hsequeda
Copy link
Collaborator

Change the path of AddressBook database file to QSetting path.
hsequeda added a commit to simelo/fibercryptowallet that referenced this issue Jan 13, 2020
@hsequeda
[addressBook] refs fibercrypto#313 - Change addressBook database path…
a2c03f3 
… to QSetting path.
@hsequeda hsequeda mentioned this issue Jan 13, 2020
Merged
hsequeda added a commit to simelo/fibercryptowallet that referenced this issue Jan 13, 2020
@hsequeda
[addressBook] ref fibercrypto#313 remove test info from init method o…
146604c 
…f addressBook model.
@olemis
Copy link
Contributor

olemis commented Jan 14, 2020

@stdevHsequeda any PR for this ?

hsequeda added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@hsequeda
[addressBook] ref fibercrypto#313 remove extra code from ui. Change s…
921022a 
…kycoin to SkycoinProject repo in addressBook model.
hsequeda added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@hsequeda
[addressBook] ref fibercrypto#313 -Created interface CoinTrait in cor…
c215af4 
…e package with GetTrait and GetValue method. Added GetCoinTraits method to Transaction, InputTransaction and outputTransaction interface.

- Implemented CoinTrait interface in util package with CoinTrait struct.
- Implemented GetCoinTrait method in all implementation of Transaction, InputTransaction and OutputTransaction.
- Added Specific Transaction Detail section in Transaction Detail dialog in the UI.
- Generated all traits for currency in Specific Transaction Detail section in Transaction Detail Dialog in the UI.
hsequeda added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@hsequeda
[addressBook] ref fibercrypto#313 -Added property walletId to address…
a3ab4ed 
…Detail in address package in the model.

-Removed AddressesModel type from the model.
-Using address.addressList and address.addressDetail where AddressesModel and QAddress was used.
-Modified fromWalletToQWallet method of walletManager to make generic the wallets.
-Modified UI of PageWallets, WalletListDelegate, WalletListAddressDelegate and SubPageSendAdvanced to use address.addressList and address.addressDetails.
hsequeda added a commit to simelo/fibercryptowallet that referenced this issue Jan 27, 2020
@hsequeda
[addressBook] ref fibercrypto#313 -Added GetCoinType function to Wall…
fdeca55 
…et interface and implemented on RemoteWallet and LocalWallet types.

- Added coin and coinOptions to QWallet type in the application model.
- Modified editWallet and updateModel method of WalletModel type in the application model.
- Modified the xxx method so that it works in a generic way in WalletManager type.
- Created DrawerWalletDetails.qml and WalletDetails.qml.
- Modified PageWallet and WalletListDelegate to use DrawerWalletDetails to show the wallet details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add QSetting to the AddressBook simelo/fibercryptowallet
2 participants
@olemis @hsequeda