msgpack, bugfix: new Boolean(false) encode error.

fibjs · Jun 14, 2021 · c1b8faa · c1b8faa
1 parent 5cd7e69
commit c1b8faa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/fibjs/include/Isolate.h b/fibjs/include/Isolate.h
@@ -96,7 +96,9 @@ class Isolate : public exlib::linkitem {
 
     bool toBoolean(v8::Local<v8::Value> v)
     {
-        return v->BooleanValue(context()).ToChecked();
+        if (v->IsBooleanObject())
+            return v8::Local<v8::BooleanObject>::Cast(v)->ValueOf();
+        return v->BooleanValue(m_isolate);
     }
 
     int64_t toInteger(v8::Local<v8::Value> v)

diff --git a/test/encoding_test.js b/test/encoding_test.js
@@ -357,11 +357,13 @@ describe('encoding', () => {
 
         it('test for true', () => {
             assert.deepEqual(true, msgpack.decode(msgpack.encode(true)));
+            assert.deepEqual(true, msgpack.decode(msgpack.encode(new Boolean(true))));
             assert.isBoolean(msgpack.decode(msgpack.encode(true)));
         });
 
         it('test for false', () => {
             assert.deepEqual(false, msgpack.decode(msgpack.encode(false)));
+            assert.deepEqual(false, msgpack.decode(msgpack.encode(new Boolean(false))));
             assert.isBoolean(msgpack.decode(msgpack.encode(false)));
         });