Permalink
Browse files

tools, feat: add .github/PULL_REQUEST_TEMPLATE.md (#439)

  • Loading branch information...
richardo2016 authored and xicilion committed Jun 22, 2018
1 parent 1adbf8d commit ced78b5ac2a567297430e02d68985d51cc0f05a7
Showing with 20 additions and 0 deletions.
  1. +20 −0 .github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,20 @@
Please fill in this template.
- [ ] Use a meaningful title for the pull request with prefix '(module|object|source_directory) [bugfix|feat|refactor|]', Such as `db, bugfix: ...`, `tools, feat: ...`
- [ ] Test the change in your own code. (Compile and run.)
- [ ] Add or edit tests to reflect the change. (Run with `fibjs test`.)
- [ ] Ensure commits history clean, merge master/dev and clean meaningless commits by `git rebase`.
Select type of change you made and delete the others:
If adding/changing one existing module or internal Object:
- [ ] Add/Change the corresponding `*.idl` file
- [ ] Run `fibjs ./tools/idlc.js` to auto-generate `*.h`, **never change it**
If removing one existing module or internal Object:
- [ ] Remove corresponding `*.h`, `*.idl`, `*.cpp`
- [ ] Remove all reference to it.
If adding internal js scripts:
- [ ] Add it to `fibjs/scripts`
- [ ] Run `fibjs ./tools/gen_script.js`

0 comments on commit ced78b5

Please sign in to comment.