Timer, feat: Compatible with Nodejs' setTimeout function, the parameter timeout can be undefined. #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2018 22:33
xicilion
reviewed
Jul 8, 2018
test/timer_test.js
Outdated
| @@ -228,20 +244,20 @@ describe("timer", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe("clearInterval in callback", () => { | |||
There was a problem hiding this comment.
提交时过滤不必要的格式化
另外 fibjs 内置了 vsc 格式化配置，所以尽量使用 vsc，以避免日后代码修改时的反复格式化
There was a problem hiding this comment.
已经处理（shift+option+f）
xicilion
reviewed
Jul 8, 2018
test/timer_test.js
Outdated
|
|
||
| GC(); | ||
| var no5 = test_util.countObject('Timer'); | ||
| assert.equal(no1 + 1, no5); |
There was a problem hiding this comment.
缺省参数可以单独一个用例，不要和已有的用例混在一起。尽量不要修改已有用例，除非存在不兼容的情况。
|
好像漏提交了 idl 文件 |
Fiber-Man
changed the title
|
idl 中英文两个文件也要提交 |
Fiber-Man
changed the title
Fiber-Man
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.