Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models.py:101: Try to remove ordering arg from... #208

Closed
0pdd opened this issue Nov 4, 2018 · 1 comment
Closed

models.py:101: Try to remove ordering arg from... #208

0pdd opened this issue Nov 4, 2018 · 1 comment
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Nov 4, 2018

The puzzle 183-a9ba47b7 from #183 has to be resolved:

refarm-site/catalog/models.py

Line 101 in fb2fa2a

# @todo #183:30m Try to remove `ordering` arg from ProductQuerySet.get_by_category

The puzzle was created by Artemiy on 04-Nov-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Nov 4, 2018
@ArtemijRodionov
#183 object compositions (#194)
fb2fa2a 
* Create catalog.context package

* Create context package

* Specify context ABS classes

* Implement base product contexts classes

* Implement base tag contexts classes

* Resolve todo and create another one for  ordering arg

* Self-review fixes

* Review fixes

* Self-review fixes
@0pdd 0pdd mentioned this issue Nov 4, 2018
Closed
@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it 2 performer can implement issue at his closest convenient time and removed 1 burning issue labels Nov 4, 2018
@ArtemijRodionov ArtemijRodionov self-assigned this Nov 4, 2018
@ArtemijRodionov ArtemijRodionov added 30 mins small issues. Usually cosmetic fixes and removed take it any teammate can take this issue and start working with it 1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i labels Nov 4, 2018
This was referenced Nov 15, 2018
Merged
Merged
Merged
ArtemijRodionov added a commit that referenced this issue Nov 16, 2018
@ArtemijRodionov
#208 Remove ordering argument from get_by_category and get_category…
6e53ade 
…_descendants (#214)
@ArtemijRodionov ArtemijRodionov added report Put it to completed tasks temporary list for business 1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i and removed 30 mins small issues. Usually cosmetic fixes labels Nov 16, 2018
@ArtemijRodionov
Copy link
Contributor

ArtemijRodionov commented Nov 18, 2018 •
edited
Loading

Test issues occurred

ArtemijRodionov added a commit to fidals/shopelectro that referenced this issue Nov 26, 2018
@ArtemijRodionov
fidals/refarm-site#208 Remove an excess argument from get_category_de…
ebfdca3 
…scendants (#633)

* Remove excess ordering field from get_category_descendants

* Fix load_more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd