Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client library updated #10

Merged
merged 2 commits into from Apr 4, 2018
Merged

client library updated #10

merged 2 commits into from Apr 4, 2018

Conversation

sergkh
Copy link
Member

@sergkh sergkh commented Apr 4, 2018

Reverts the recent changes made in the client library with manual scanning. Also upgraded build tools and gradle as Android studio told me.

@sergkh sergkh requested a review from monday8am April 4, 2018 13:30
@monday8am
Copy link
Contributor

I only see the gradle modifications. If you're in the mood, you can replace the word compile by the word implementation (testCompile -> testImplementation). It will be deprecated in new versions.

monday8am
monday8am approved these changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@monday8am monday8am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me! 👍

@sergkh
Copy link
Member Author

sergkh commented Apr 4, 2018

there's a small change with client version update :) Sure, will replace them

@sergkh sergkh merged commit 69f243b into master Apr 4, 2018
@sergkh sergkh deleted the client-lib-upgrade branch April 4, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monday8am monday8am monday8am approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sergkh @monday8am