build with gcc 6 #887
Assignees
Milestone
Comments
|
@vtchill @stubb can you please take an look on it please? @grauschnabel thx for the report :-) |
|
Will take a look on it at the weekend |
diff --git a/engine/core/view/renderers/targetrenderer.cpp b/engine/core/view/renderers/targetrenderer.cpp
index 9f677fa..dd47b61 100644
--- a/engine/core/view/renderers/targetrenderer.cpp
+++ b/engine/core/view/renderers/targetrenderer.cpp
@@ -136,7 +136,7 @@ namespace FIFE {
rj.discard = false;
std::pair<RenderJobMap::iterator, bool> ret =
- m_targets.insert(std::make_pair<std::string, RenderJob>(name, rj));
+ m_targets.insert(std::make_pair(name, rj));
return ret.first->second.target;
}
@@ -149,7 +149,7 @@ namespace FIFE {
rj.discard = false;
std::pair<RenderJobMap::iterator, bool> ret =
- m_targets.insert(std::make_pair<std::string, RenderJob>(image->getName(), rj));
+ m_targets.insert(std::make_pair(image->getName(), rj));
return ret.first->second.target;
}
I removed the explicit provided type, so the compiler can deduce it by itself. |
|
Can this fix into master? |
|
Thats a patch for version 0.3.5. Needs to be tested with master. |
|
that patch works fine for me with master on gcc6 |
|
This is not fixed, see this build log from openSUSE: https://build.opensuse.org/build/games/openSUSE_Tumbleweed/i586/fife/_log |
|
Can you please attatch the log here? We cant see it as anyomus user. |
|
Oh sorry for that, here it is: http://www.susepaste.org/4672105 |
|
Are you using the git version? |
|
No, it's FIFE 0.3.5 with the patch applied, as i mentioned in my first comment. |
|
Could you maybe test the git version? |
|
I will try it ASAP |
|
Hi, if you guys have fix it, I'm getting this on Ubuntu 16.4 LTS ... |
|
@Maraschin our next "stable" fife release will come this month. Dont use Ubuntus Fife version from the repo compile it by your own or wait to the stable version ist out and the the ubuntu maintainer have updated it. |
|
0.4.0 is out wait that your distro update fife. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there,
It seems, this cannot be built with gcc 6. Can you give me a fix?
see for exaple: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=811858
this issue also exists on arch linux, where gcc 6 is default allready
The text was updated successfully, but these errors were encountered: