Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for long-standing bugs & powersave #12

Merged
merged 6 commits into from Apr 20, 2020
Merged

Conversation

@dbeinder
Copy link

@dbeinder dbeinder commented Apr 20, 2020

This should fix:

  • connecting to unsecured networks
  • extremely long delays / losses on incoming frames in powersave mode
  • unreliable scanning: scan used to show only half the APs in range, this is definitely fixed
  • wonky rate selection: Not 100% sure about this, but I've gotten about 2x higher throughput on a connection with bad signal
  • powersave now configurable using iwconfig
  • saves ~200mW with powersave on
  • with powersave off: single digit millisecond pings both directions

Tested on OrangePi Zero LTS

dbeinder added 6 commits Apr 19, 2020
cfg80211_get_bss needs explicit flags to get networks without privacy
Without info element, probe requests are invalid and most APs do not respond to them. On passive scan: listen for a full 100TU to get all standard beacons
5.5Mb and 11Mb do work in CCK mode, only PBCC modulation is unsupported
Also, adapt some debug build remnants
Leave rate/retry selection to the minstrel rate adaption algorithm. Fixes wrong-item bug in TX retry policy cache due to questionable optimizations. Rewritten feedback parsing to pass correct retry counts back to minstrel. Seems to increase data rate and stability.
wsm_set_beacon_wakeup_period() expects a number of beacons, not milliseconds. This makes powersave mode less prone to dropping frames. For less delayed & more reliable incoming frames, allow disabling powersave through iwconfig. Let's keep powersave active by default though, since it is saves almost 500mW on an idle connection.
@fifteenhex fifteenhex merged commit 6bf0e2e into fifteenhex:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants