{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":759457304,"defaultBranch":"main","name":"python-project-49","ownerLogin":"fiftinmen","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2024-02-18T16:42:21.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/154807624?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1718966820.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"00b51c3bed07f02e6340f823e777473fb234f9a1","ref":"refs/heads/old","pushedAt":"2024-06-21T10:47:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"make 6 min progression","shortMessageHtmlLink":"make 6 min progression"}},{"before":"cbc8df3ef02cc867931f187d852218484739099a","after":"9868e00bcb5635cdb4d306e95595ee9380071fab","ref":"refs/heads/main","pushedAt":"2024-06-21T10:36:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix import","shortMessageHtmlLink":"fix import"}},{"before":"9e87e738e5e599afdb007b6dd6c0f6a78e9a13cd","after":"cbc8df3ef02cc867931f187d852218484739099a","ref":"refs/heads/main","pushedAt":"2024-06-21T10:30:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"make min progresssion len 6","shortMessageHtmlLink":"make min progresssion len 6"}},{"before":"775c7e4f0509db0526b68c06e43e28915a192e20","after":"9e87e738e5e599afdb007b6dd6c0f6a78e9a13cd","ref":"refs/heads/main","pushedAt":"2024-04-23T11:30:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix style","shortMessageHtmlLink":"fix style"}},{"before":"605801c2343440a58b60747e199d92188f6aa5d9","after":"775c7e4f0509db0526b68c06e43e28915a192e20","ref":"refs/heads/main","pushedAt":"2024-04-23T11:27:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix is_prime function","shortMessageHtmlLink":"fix is_prime function"}},{"before":"7c77e9837e54f4f6780110b4bdc7ea44783588e2","after":"605801c2343440a58b60747e199d92188f6aa5d9","ref":"refs/heads/main","pushedAt":"2024-04-23T09:18:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"refactoring","shortMessageHtmlLink":"refactoring"}},{"before":"ff5df900222892730398bc251db1c8e801c40e6c","after":"7c77e9837e54f4f6780110b4bdc7ea44783588e2","ref":"refs/heads/main","pushedAt":"2024-04-22T15:14:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"remove comma from progression","shortMessageHtmlLink":"remove comma from progression"}},{"before":"fa47b52dae2d0eed079ef5046fcc56e164260b71","after":"ff5df900222892730398bc251db1c8e801c40e6c","ref":"refs/heads/main","pushedAt":"2024-04-22T15:10:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix progression question generator","shortMessageHtmlLink":"fix progression question generator"}},{"before":"3009e5e6fe26483aca90954b71915eb85f770775","after":"fa47b52dae2d0eed079ef5046fcc56e164260b71","ref":"refs/heads/main","pushedAt":"2024-04-22T14:52:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"refactoring","shortMessageHtmlLink":"refactoring"}},{"before":"905828510aea7fa22eb0e6a1a1fa7f8e1a73ab6e","after":"3009e5e6fe26483aca90954b71915eb85f770775","ref":"refs/heads/main","pushedAt":"2024-04-11T17:37:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"refactor","shortMessageHtmlLink":"refactor"}},{"before":"52bcdc8ef8cde5d953171eb590993fdf1a98a31a","after":"905828510aea7fa22eb0e6a1a1fa7f8e1a73ab6e","ref":"refs/heads/main","pushedAt":"2024-04-11T17:28:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"remove common_functions.py from repository","shortMessageHtmlLink":"remove common_functions.py from repository"}},{"before":"49d965d251f4f464279798b0cd5d6c609e0547ef","after":"52bcdc8ef8cde5d953171eb590993fdf1a98a31a","ref":"refs/heads/main","pushedAt":"2024-04-04T20:14:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"1. move game() calls to game scripts\n2. move constants in game modules before functions\n3. remove game_engine import from game modules","shortMessageHtmlLink":"1. move game() calls to game scripts"}},{"before":"f6d55da4ddd183b798d24f59d3cbb5e31628a874","after":"49d965d251f4f464279798b0cd5d6c609e0547ef","ref":"refs/heads/main","pushedAt":"2024-04-02T14:56:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix call game in game-even","shortMessageHtmlLink":"fix call game in game-even"}},{"before":"1e4ff756b5c83a2b9bbd036388623492a59540dc","after":"f6d55da4ddd183b798d24f59d3cbb5e31628a874","ref":"refs/heads/main","pushedAt":"2024-04-02T14:52:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"refactor call of game()","shortMessageHtmlLink":"refactor call of game()"}},{"before":"c9c150ca942b19fb5057b5c48ad70aebd9b3886a","after":"1e4ff756b5c83a2b9bbd036388623492a59540dc","ref":"refs/heads/main","pushedAt":"2024-04-02T14:32:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix style","shortMessageHtmlLink":"fix style"}},{"before":"066bc922c669f568d03e9d8d7d9d243188635a1f","after":"c9c150ca942b19fb5057b5c48ad70aebd9b3886a","ref":"refs/heads/main","pushedAt":"2024-04-02T14:13:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"refactor code; remove magic numbers; move game modules and game engine","shortMessageHtmlLink":"refactor code; remove magic numbers; move game modules and game engine"}},{"before":"f591d31bb5bfc6e4cb7cdfb736751efa0bd35820","after":"066bc922c669f568d03e9d8d7d9d243188635a1f","ref":"refs/heads/main","pushedAt":"2024-03-27T15:22:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"remove redundant\nlines","shortMessageHtmlLink":"remove redundant"}},{"before":"6c165f2d2495b8ed96b34276957add25e91cf72a","after":"f591d31bb5bfc6e4cb7cdfb736751efa0bd35820","ref":"refs/heads/main","pushedAt":"2024-03-27T15:21:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"untrack binaries","shortMessageHtmlLink":"untrack binaries"}},{"before":"ac7f74fe895c45a8a9f1b4f79094b19ff4f0f259","after":"6c165f2d2495b8ed96b34276957add25e91cf72a","ref":"refs/heads/main","pushedAt":"2024-03-27T15:12:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix style","shortMessageHtmlLink":"fix style"}},{"before":"887cfa05d51612a4e1442d9402370610a156d77c","after":"ac7f74fe895c45a8a9f1b4f79094b19ff4f0f259","ref":"refs/heads/main","pushedAt":"2024-03-27T15:01:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix style","shortMessageHtmlLink":"fix style"}},{"before":"81a80332dba7a24e0a56e9df595deb8daa0fcbaf","after":"887cfa05d51612a4e1442d9402370610a156d77c","ref":"refs/heads/main","pushedAt":"2024-03-27T14:50:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix style","shortMessageHtmlLink":"fix style"}},{"before":"07bc70b7571784bc3269f4b8fd92d9155f6d5078","after":"81a80332dba7a24e0a56e9df595deb8daa0fcbaf","ref":"refs/heads/main","pushedAt":"2024-03-27T14:43:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix style","shortMessageHtmlLink":"fix style"}},{"before":"cb96ee6c6dde5e8e17c91be566c03da194a0b674","after":"07bc70b7571784bc3269f4b8fd92d9155f6d5078","ref":"refs/heads/main","pushedAt":"2024-03-27T14:32:11.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"remove brackets for negative integers in brain_calc expressions","shortMessageHtmlLink":"remove brackets for negative integers in brain_calc expressions"}},{"before":"dd771400cd2ac8646e942984eae0373da9a09f12","after":"cb96ee6c6dde5e8e17c91be566c03da194a0b674","ref":"refs/heads/main","pushedAt":"2024-03-27T14:08:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"refactor evaluate_expression function in calc_game.py; fix BRAIN_GAME_PROMPT in even_game.py","shortMessageHtmlLink":"refactor evaluate_expression function in calc_game.py; fix BRAIN_GAME…"}},{"before":"c16ccbe273a0372a3f10ab844012b218200a58c3","after":"dd771400cd2ac8646e942984eae0373da9a09f12","ref":"refs/heads/main","pushedAt":"2024-03-27T13:44:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"Fix game-prompts in game-even.py and game-prime.py","shortMessageHtmlLink":"Fix game-prompts in game-even.py and game-prime.py"}},{"before":"614f9190c3bfab107f37c8ee8efe17f289017493","after":"c16ccbe273a0372a3f10ab844012b218200a58c3","ref":"refs/heads/main","pushedAt":"2024-03-27T13:31:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"Update README.md","shortMessageHtmlLink":"Update README.md"}},{"before":"2f290b6b7248857e95645953ca565abc4eed2e5d","after":"614f9190c3bfab107f37c8ee8efe17f289017493","ref":"refs/heads/main","pushedAt":"2024-03-27T13:24:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"Refactor by this comments from tutor:\n\nЛишние файлы и вынести игры в отдельные модули из scripts.\n\nвса папки и файлы в __pycache__ нужно удалить из репозитория и добавить в .gitignore. Это временные файлы, которые создаются во время запуска программы.\nhttps://github.com/fiftinmen/python-project-49/blob/2f290b6b7248857e95645953ca565abc4eed2e5d/brain_games/scripts/__pycache__/__init__.cpython-310.pyc#L1\n\nлучше пользоваться абсолютными импортами, from brain_games import .... Если мы куда то переместим файл brain_calc.py, то придется исправлять импорты.\nhttps://github.com/fiftinmen/python-project-49/blob/2f290b6b7248857e95645953ca565abc4eed2e5d/brain_games/scripts/games/brain_calc.py#L6-L7\n\nпеременные обозначающие количество чего-либо обычно называют с суффиксом _COUNT\nhttps://github.com/fiftinmen/python-project-49/blob/2f290b6b7248857e95645953ca565abc4eed2e5d/brain_games/scripts/games/brain_calc.py#L14\n\n2 - это magic number, нужно его вынести в константы уровня модуля и дать понятное название\nhttps://ru.hexlet.io/blog/posts/magic-numbers\n\nhttps://github.com/fiftinmen/python-project-49/blob/2f290b6b7248857e95645953ca565abc4eed2e5d/brain_games/scripts/games/brain_calc.py#L18\n\neval не очень безопасная функция, потому что позволяет выполнить произвольный код а это может быть небезопасно. Тут лучше реализовать вычисление значения выражения через if .. elif .. elif\nhttps://github.com/fiftinmen/python-project-49/blob/2f290b6b7248857e95645953ca565abc4eed2e5d/brain_games/scripts/games/brain_calc.py#L24\n\nконстанты уровня модуля называют в верхнем регистре. rules - это множественное число, обычно так называют коллекции.\nhttps://github.com/fiftinmen/python-project-49/blob/2f290b6b7248857e95645953ca565abc4eed2e5d/brain_games/scripts/games/brain_calc.py#L31\n\nв папке scripts должны быть файлы с минимумом кода. В этих файлах должны только импортироваться функции и вызываться.\nhttps://github.com/fiftinmen/python-project-49/blob/2f290b6b7248857e95645953ca565abc4eed2e5d/brain_games/scripts/\n\nТолько вот этот код. А функции гереации вопроса ответа - вынесены в отдельные модули - brain_games/games/ и импортироваться оттуда.\n\nhttps://github.com/fiftinmen/python-project-49/blob/2f290b6b7248857e95645953ca565abc4eed2e5d/brain_games/scripts/games/brain_calc.py#L34-L42\n\n3 - это тоже magic number. Вынести в константу модуля.\nhttps://github.com/fiftinmen/python-project-49/blob/2f290b6b7248857e95645953ca565abc4eed2e5d/brain_games/scripts/brain_engine.py#L12","shortMessageHtmlLink":"Refactor by this comments from tutor:"}},{"before":"8ff6af125995f5020d3ea85298a99315817b9d26","after":"2f290b6b7248857e95645953ca565abc4eed2e5d","ref":"refs/heads/main","pushedAt":"2024-03-18T12:45:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix intendation of bracket","shortMessageHtmlLink":"fix intendation of bracket"}},{"before":"bae4af752bfdcc0495dc2c05f7f46def61be4607","after":"8ff6af125995f5020d3ea85298a99315817b9d26","ref":"refs/heads/main","pushedAt":"2024-03-18T12:40:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix style","shortMessageHtmlLink":"fix style"}},{"before":"a5c2c82cf27afa389de7c499449354aebe61a1c3","after":"bae4af752bfdcc0495dc2c05f7f46def61be4607","ref":"refs/heads/main","pushedAt":"2024-03-18T12:31:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fiftinmen","name":"Fiftinmen","path":"/fiftinmen","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154807624?s=80&v=4"},"commit":{"message":"fix word in rules to go through tests","shortMessageHtmlLink":"fix word in rules to go through tests"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEa3z35wA","startCursor":null,"endCursor":null}},"title":"Activity · fiftinmen/python-project-49"}