Update Readme.md #2

Open
wants to merge 1 commit into
from

Projects

None yet

4 participants

Previous Code has Error

@zr40 zr40 commented on the diff Jul 20, 2012
Readme.md
@@ -16,7 +16,7 @@ If you want to support the efforts to stop American censorship, add this to your
```html
<script type="text/javascript"> var CloudFlare = CloudFlare || []; </script>
-<script type="text/javascript" src="//ajax.cloudflare.com/cdn-cgi/nexp/cloudflare.js" async></script>
+<script type="text/javascript" src="//ajax.cloudflare.com/cdn-cgi/nexp/cloudflare.js"></script>
zr40
zr40 Jul 20, 2012

async is not an error, and should not be removed. Without async, the browser will pause parsing the document until the script has downloaded.

@zr40 zr40 commented on the diff Jul 20, 2012
Readme.md
@@ -24,8 +24,8 @@ If you want to support the efforts to stop American censorship, add this to your
"twitterHandle" : null, // Your Twitter handle; if not provided, your website domain will be used.
"position_x" : "right", // Badge position - right or left
- "selector" : "p, h1, .censor_me" // Optional selector for elements to censor. Remove for default.
- "persistant" : true, // If true, page will always show black bars; if false, it will only show them on the first visit
+ "selector" : "p, h1, .censor_me", // Optional selector for elements to censor. Remove for default.
+ "persistant" : true // If true, page will always show black bars; if false, it will only show them on the first visit
zr40
zr40 Jul 20, 2012

No need to remove the final ,. It's optional and doesn't hurt. In fact, it helps prevent the error you corrected on line 27, since you don't have to add the , when adding a new property.

VenomVendor
VenomVendor Jul 20, 2012

Thanks for the info, I am Talking from Google Blogger point of view, I am
getting error if i am using

<script type="text/javascript" src="//ajax.cloudflare.com/cdn-cgi/nexp/cloudflare.js" async></script>

Removing "Async" is working,
Adding "," at the end is not giving any issue, But missing "," after
"selector" : "p, h1, .censor_me", i dont get any error & i dont get the
censored image too.

On Fri, Jul 20, 2012 at 12:56 PM, Matthijs van der Vleuten <
reply@reply.github.com

wrote:

@@ -24,8 +24,8 @@ If you want to support the efforts to stop American
censorship, add this to your

     "twitterHandle" : null, // Your Twitter handle; if not

provided, your website domain will be used.
"position_x" : "right", // Badge position - right or left

  •    "selector" : "p, h1, .censor_me" // Optional selector for
    
    elements to censor. Remove for default.
  •    "persistant" : true, // If true, page will always show black
    
    bars; if false, it will only show them on the first visit
  •    "selector" : "p, h1, .censor_me", // Optional selector for
    
    elements to censor. Remove for default.
  •    "persistant" : true // If true, page will always show black
    
    bars; if false, it will only show them on the first visit

No need to remove the final ,. It's optional and doesn't hurt. In fact,
it helps prevent the error you corrected on line 27, since you don't have
to add the , when adding a new property.


Reply to this email directly or view it on GitHub:

https://github.com/fightforthefuture/internet_defense_league/pull/2/files#r1203498

dfreeman
dfreeman Jul 25, 2012

Actually, the final , can hurt.
Pedantically, the JSON spec disallows it, and more practically, some browsers will throw a syntax error with the trailing comma under the right (read: fairly common) conditions.

Tif said the guys from WordPress were into using this, but they need it as responsive. I'm rusty guys, seriously rusty, way rusty but if you don't mind backing me up, or me yelling for help, I'll give her a shot and if I don't have it done by over the weekend, someone else can take over K?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment