Bug Submitter: use the same dialog instance again after failure #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialog - by running dialog.resetForm() which sets askedToSubmit = false
|
I missed the fact that the dialog will be displayed again and again even when the user cancels, if they tried to submit once. Fixed in the second commit. |
dscho
added a commit
that referenced
this pull request
Jun 25, 2014
Bug Submitter: use the same dialog instance again after failure
|
Thank you! |
Ah, completely my fault, sorry. I missed the fact that our Will fix in a moment. |
This is fixed as per http://jenkins.imagej.net/view/Fiji/job/Fiji-Maven/ build 824. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Bug #816 in Fiji's bugzilla:
http://fiji.sc/bugzilla/show_bug.cgi?id=816
I had minor troubles when building with Maven: imagej-updater-0.3.9.jar gets deleted and replaced by an earlier version (0.2.0, or 0.3.6 if I removed the version tag in pom.xml). When I removed the imagej-updater dependency completely (thinking that it's implied by pom-fiji), I got compile errors, so I left it in, but had to put back the newest imagej-updater.jar in Fiji.app/jars in order to be able to start Fiji.