-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop shipping unshaded fat jars #83
Comments
|
The proposed fixed of deleting jruby-complete.jar does not appear to work anymore to fix jython os.path modules.. i am still getting the error after deleting jruby-complete |
|
See also Fiji BugZilla bug #741. |
|
As a workaround, you can delete I figured this out as follows:
Note the warning that appears about how the class is present in two different locations. |
|
I fixed Jython. And we already split up JRuby. That just leaves Batik, I think! |
Components that wish to depend on batik should do so using the official org.apache.xmlgraphics groupId, not the batik:batik uber-JAR. See also: fiji/fiji#83
Instead, pom-scijava now manages all the org.apache.xmlgraphics:batik-* component artifacts. This avoids problems with uber-JARs; see: fiji/fiji#83
|
Progress: Releases coming soon! Then batik will be fixed, and Fiji will no longer ship any uber-JARs. |
|
All is complete, and uploaded to the Java-8 update site. However, there is currently a bug in the updater which prevents marking files obsolete on downstream update sites. So, I cannot remove the old batik uber-JAR yet. As soon as we find a workaround, I'll close this issue. |
|
@ctrueden : The workflow (of opening an .msr file with the Java8 update site enabled) works without any issues on the Bio-Formats side, on Windows. (This was previously failing due to dependency clashes) |
|
@bramalingam Thanks for the feedback. Glad it is working for your needs. I will close this issue now since all is resolved on the coding side. The removal of the |
A "fat jar" is a JAR that bundles some or all of its dependencies with it. This may be fine if the dependencies are shaded (i.e., their packages are renamed). But in many cases such as the JRuby and Jython uberjars, at least some of the dependencies are not shaded. This causes problems because there are often then multiple versions of the same library available on the classpath from multiple fat jars. To avoid this problem, the Fiji update site should not include any such unshaded fat jars, but instead ship only individual JAR libraries for all its components.
The text was updated successfully, but these errors were encountered: