Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Making the names of the css classes to be used configureable #26

Merged
merged 1 commit into from Jul 24, 2013

Conversation

Projects
None yet
3 participants
Contributor

cburgdorf commented Mar 21, 2013

It would be great if one could use custom names for the classes.

Use case:

  • you might already have a scrollable class that matches the definition of the overthrow class and you don't want to change your code or add another class with the same definition but different name
  • you have specific conventions for your class names.
  • you are a pedantic moron like me
Contributor

cburgdorf commented Mar 21, 2013

I also added tests

Owner

scottjehl commented Mar 22, 2013

Hey this is nice! I'll need some time to look it over - we're pretty slammed. Consider it tentatively approved. thanks for sending :)

Member

Wilto commented Mar 22, 2013

You had me at “I also added tests.”

Contributor

cburgdorf commented Mar 22, 2013

Thanks for the positive feedback. Let me know if it needs further tweaking (e.g. the variable names could be better maybe)

@scottjehl scottjehl merged commit d73c2aa into filamentgroup:master Jul 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment