Skip to content

Compatibility issue with jquery 1.8.x #9

Closed
slcoleg opened this Issue Sep 10, 2012 · 1 comment

3 participants

@slcoleg
slcoleg commented Sep 10, 2012

Starting from 1.8.0 visualize.jQuery shows no charts due the .filter() compatibility issue.
Simple any code fragment similar to this one
self.find('tr:gt(0)').filter(o.rowFilter)
or
$(this).find('td').filter(o.colFilter)
returns null.

Works fine if the filter(o.rowFilter) or filter(o.colFilter) just not called at all.

What is the purpose for filtering?

Thanks,

O

@zipang
zipang commented Sep 15, 2012

To fix this issue (that i experimented too with my forked version https://github.com/zipang/jQuery-Visualize),
i had to change the initialization values of colFilter and rowFilter to "*" :

//configuration
var o = $.extend({ // (other options omitted here for brevity)
    (...)
    rowFilter: '*',
    colFilter: '*',
    (...)
},options);
@scottjehl scottjehl pushed a commit that closed this issue Nov 15, 2012
Scott Jehl tweaked the default values for rowFilter and colFilter to work with j…
…Query 1.8+. Fixes #9
a78d8a3
@scottjehl scottjehl closed this in a78d8a3 Nov 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.