New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Bug - Crash issues with Version <= 41 and loadCSS v2.0.1 #261

Open
duply opened this Issue Jan 26, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@duply

duply commented Jan 26, 2018

Hi,

I recently updated to loadCSS v.2.0.1 and noticed that older Firefox Versions completely crash the Browser on pageload.
Using Browserstack I narrowed it down to Firefox 41 and below. Not exactly sure what's causing this. Reverting back to loadCSS v1.3.1 resolved the issue though.

I can reproduce the error using the demo page and Firefox 41:
https://master-origin-loadcss.fgview.com/test/preload.html

@gaaarg

This comment has been minimized.

Show comment
Hide comment
@gaaarg

gaaarg Apr 5, 2018

Hello,

Any updates about this issue ?
Is it something the filamentgroup will plan to fix?

gaaarg commented Apr 5, 2018

Hello,

Any updates about this issue ?
Is it something the filamentgroup will plan to fix?

@rsteinwand

This comment has been minimized.

Show comment
Hide comment
@rsteinwand

rsteinwand Apr 13, 2018

I can confirm it's a problem for my website as well.

But I have no clue if any of our customers use FF 41.

rsteinwand commented Apr 13, 2018

I can confirm it's a problem for my website as well.

But I have no clue if any of our customers use FF 41.

@ryantoft-gm

This comment has been minimized.

Show comment
Hide comment
@ryantoft-gm

ryantoft-gm Apr 13, 2018

Usage on FF 41 and earlier is going to be low. But the fact that it crashes the whole browser is pretty rough.

For what it's worth it looks like the issue was introduced in this commit - likely related to the way the load handlers were changed: afa545b

ryantoft-gm commented Apr 13, 2018

Usage on FF 41 and earlier is going to be low. But the fact that it crashes the whole browser is pretty rough.

For what it's worth it looks like the issue was introduced in this commit - likely related to the way the load handlers were changed: afa545b

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Apr 13, 2018

Member

good to know thanks!

Member

scottjehl commented Apr 13, 2018

good to know thanks!

@gaaarg

This comment has been minimized.

Show comment
Hide comment
@gaaarg

gaaarg Sep 11, 2018

FYI
It was said in the #262 discussion that the 918a331 resolve also this issue. I test it and it works fine in FF 41.

So it seems that using the last version of the master branch (but not tagged) fix this.
Any reason why this commit has not been tagged ?

Link to the CSS PreLoad function that I used:
https://github.com/filamentgroup/loadCSS/blob/918a3318f055002b4bee729840e420e057637c7a/src/cssrelpreload.js

gaaarg commented Sep 11, 2018

FYI
It was said in the #262 discussion that the 918a331 resolve also this issue. I test it and it works fine in FF 41.

So it seems that using the last version of the master branch (but not tagged) fix this.
Any reason why this commit has not been tagged ?

Link to the CSS PreLoad function that I used:
https://github.com/filamentgroup/loadCSS/blob/918a3318f055002b4bee729840e420e057637c7a/src/cssrelpreload.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment