Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Problems Modifying Swipe Values Via Tablesaw.config #79

Closed
relaxatorium opened this issue Dec 18, 2014 · 0 comments
Closed

Problems Modifying Swipe Values Via Tablesaw.config #79

relaxatorium opened this issue Dec 18, 2014 · 0 comments
Assignees

Comments

@relaxatorium
Copy link
Contributor

I am having trouble getting the swipe configuration introduced in 6391d4c to actually be applied to the plugin.

Steps to reproduce:

  • on the swipe-config.html demo, change values to something obviously different/crazy such as
    Tablesaw.config = {
        swipe: {
            horizontalThreshold: 15000, // default is 15
            verticalThreshold: 30000 // default is 20
        }
    };
  • Make sure your browser is actually mobile or you're debugging in chrome emulating mobile or something like that
  • Set a breakpoint on line 759 of the combines javascript file
if( x - originX < -1 * config.horizontalThreshold ){
  • in the console, inspect "Tablesaw.config.swipe" and also "config"
  • Tablesaw.config.swipe will have the weird values, eg. {horizontalThreshold: 15000, verticalThreshold: 30000}, but the actual "config" variable being used retains its default values, eg. {horizontalThreshold: 15, verticalThreshold: 30}
@zachleat zachleat self-assigned this Jan 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants