Add third argument to FontFace contructor, fix #2 #3

Merged
merged 1 commit into from Dec 30, 2014

Conversation

Projects
None yet
2 participants
@CrocoDillon
Contributor

CrocoDillon commented Dec 29, 2014

This argument, FontFaceDescriptors, is optional according to spec but
causes some browsers (Chrome 35 and 36, Opera 22 and 23) to throw an
error.

Uncaught TypeError: Failed to construct 'FontFace': 3 arguments required, but only 2 present.
Add third argument to FontFace contructor, fix #2
This argument, `FontFaceDescriptors`, is optional according to spec but
causes some browsers (Chrome 35 and 36, Opera 22 and 23) to throw an
error.

zachleat added a commit that referenced this pull request Dec 30, 2014

Merge pull request #3 from CrocoDillon/master
Add third argument to FontFace contructor, fix #2

@zachleat zachleat merged commit 28a31f3 into filamentgroup:master Dec 30, 2014

@zachleat

This comment has been minimized.

Show comment
Hide comment
@zachleat

zachleat Dec 30, 2014

Member

Thank you!

Member

zachleat commented Dec 30, 2014

Thank you!

@zachleat zachleat self-assigned this Dec 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment