Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add third argument to FontFace contructor, fix #2 #3

Merged
merged 1 commit into from Dec 30, 2014

Conversation

@CrocoDillon
Copy link
Contributor

CrocoDillon commented Dec 29, 2014

This argument, FontFaceDescriptors, is optional according to spec but
causes some browsers (Chrome 35 and 36, Opera 22 and 23) to throw an
error.

Uncaught TypeError: Failed to construct 'FontFace': 3 arguments required, but only 2 present.
This argument, `FontFaceDescriptors`, is optional according to spec but
causes some browsers (Chrome 35 and 36, Opera 22 and 23) to throw an
error.
zachleat added a commit that referenced this pull request Dec 30, 2014
Add third argument to FontFace contructor, fix #2
@zachleat zachleat merged commit 28a31f3 into filamentgroup:master Dec 30, 2014
@zachleat
Copy link
Member

zachleat commented Dec 30, 2014

Thank you!

@zachleat zachleat self-assigned this Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.