Cannot use trans in panel config after upgrade

[datlechin]

Package

filament/filament

Package Version

v3.0.14

Laravel Version

v10.18.0

Livewire Version

No response

PHP Version

PHP 8.2

Problem description

Cannot use translation in panel config after upgrade from v3.0.8 to v3.0.14

Target class [translator] does not exist.

            ->userMenuItems([
                MenuItem::make()
                    ->label(__('My Profile')) // error right here
                    ->url(fn () => Profile::getUrl())
                    ->icon('heroicon-o-user-circle'),
            ]);

Expected behavior

works

Steps to reproduce

Use trans() or __() in admin panel service

Reproduction repository

https://github.com/datlechin/filament

Relevant log output

No response

[nielspeen]

As you came from 3.0.8, I can confirm this starts with 3.0.14. Downgrading to 3.0.13 fixes it.

[howdu]

I had a similar issue- solved by using a closure ->label(() => __('My Profile'))

[datlechin]

@howdu how about this

            ->navigationGroups([
                __('Courses'),
                __('Blog'),
                __('Forum'),
                __('Administration'),
            ])

[howdu]

Use the full class

->navigationGroups([
    NavigationGroup::make()
        ->label(fn () => __('Example'))
        ->collapsible(),
    NavigationGroup::make()
        ->label(fn () => __('Example'))
        ->collapsible(),
])

[datlechin]

It works btw I don't think this is a good way to solve this issue

[danharrin]

Correct me if I'm wrong. In 3.0.13, using __() does not actually translate anything, if you set the locale in middleware. It just uses your default locale. You have to actually wrap it in a closure to be able to translate.

[datlechin]

ok, you're right. before v3.0.13 translate takes no effect without closure function.

[danharrin]

So this is probably a good error lol. It was kinda a coincidence that it worked before. There is no way to access the locale from a service provider, as it is run before middleware.

[lloricode]

Correct me if I'm wrong. In 3.0.13, using __() does not actually translate anything, if you set the locale in middleware. It just uses your default locale. You have to actually wrap it in a closure to be able to translate.

Hi!, same issue as mine, using filament v3.0.15

It is working on this:

            ->navigationItems([
                NavigationItem::make('API Documentation')
                    ->group(fn () => trans('Documentation'))

But this is not working

            ->navigationGroups([
                fn () => trans('Documentation'),
            ])

is there any wrong on my setup? hope can fix this

[lloricode]

Correct me if I'm wrong. In 3.0.13, using __() does not actually translate anything, if you set the locale in middleware. It just uses your default locale. You have to actually wrap it in a closure to be able to translate.

Hi!, same issue as mine, using filament v3.0.15

It is working on this:

            ->navigationItems([
                NavigationItem::make('API Documentation')
                    ->group(fn () => trans('Documentation'))

But this is not working

            ->navigationGroups([
                fn () => trans('Documentation'),
            ])

is there any wrong on my setup? hope can fix this

My bad, there is a way

            ->navigationGroups([
                NavigationGroup::make()
                    ->label( fn () => trans('Documentation')),

[twarkie]

I'm forcing my filament language to english with this code in AdminPanelProvider.php:

app()->setLocale('en');

...which also results in Target class [translator] does not exist. after upgrade from 3.0.12 to 3.0.16.

[danharrin]

Should be fixed by #7661

[alphyon]

I have same issue using v3.0.36