Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use-after-free with large file -f list #121

Closed
wants to merge 1 commit into from
Closed

Fix use-after-free with large file -f list #121

wants to merge 1 commit into from

Conversation

fweimer-rh
Copy link

This results in crashes during Fedora rawhide package builds: https://bugzilla.redhat.com/show_bug.cgi?id=2110622

sgallagher
sgallagher approved these changes Jul 27, 2022
View reviewed changes
Copy link

@sgallagher sgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Without this change, the realloc() was effectively useless and leaking memory while the existing memory was being reused and overwriting past its allocation.

@zoulasc
Copy link
Contributor

zoulasc commented Jul 30, 2022

committed

@zoulasc zoulasc closed this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgallagher sgallagher sgallagher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fweimer-rh @zoulasc @sgallagher