Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to set --auth.method to update auth settings #715

Closed
hacdias opened this issue Apr 20, 2019 · 2 comments

Comments

@hacdias
Copy link
Member

commented Apr 20, 2019

Description

Trying to change the authentication settings.

Expected behaviour

I'd run:

filebrowser config set --recaptcha.key=key --recaptcha.secret=secret

And the configurations (if using the JSON Auth Method) would update correctly.

What is happening instead?

The configurations aren't changing.

Additional context

We need to set --auth.method every time we want to change the authentication settings. This applies to all types of authentication and not only json. Also, by setting this flag, we override the current auth configurations which might not be useful in some cases.

This will take some rework on the config set code to make this work. I'll update the documentation in the meanwhile so people know. If someone wants to take a stab at this bug, we'll all be greateful ❤️

How to reproduce?

Run the command above.

Files

N/A

@hacdias hacdias added the bug 🐞 label Apr 20, 2019

@hacdias hacdias changed the title Need to set --auth.method to update authentication related settings Need to set --auth.method to update auth settings Apr 20, 2019

@hacdias hacdias closed this in 6e48a6b May 20, 2019

hacdias added a commit that referenced this issue May 20, 2019

Make --auth.method parameter optional when changing auth parameters F…
…ixes: #715 (#732)

Make --auth.method parameter optional when changing auth parameters Fixes: #715
@chummumm

This comment has been minimized.

Copy link

commented Jun 16, 2019

can I set recaptcha in config.json?

@hacdias

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

@chummumm not right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.