Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use commit SHA as version if not release #505

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
2 participants
@1138-4EB
Copy link
Collaborator

commented Aug 9, 2018

This PR replaces the (untracked) version with the first eight characters of the commit that is being built when USE_DOCKER="true" ./build/build_all.sh is used. If executed outside of a docker container envvar COMMIT_SHA can be set to any value and that will be used.

Since build.sh is not executed when commits are tagged, this does not apply to releses.

Also, dep ensure --update was executed in order to update Gopkg.lock.

@1138-4EB

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 9, 2018

I don't know why, this and some other PRs (#497, #504) are not being executed in travis.

@hacdias

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

@1138-4EB on travisstatus.com it says «Partially Degraded Service». It might be because of that.

This was referenced Aug 9, 2018

@1138-4EB 1138-4EB force-pushed the master branch 3 times, most recently from 46b9765 to 714876e Aug 16, 2018

@1138-4EB 1138-4EB force-pushed the chore/commit-sha branch from 956191a to be14b7d Aug 16, 2018

@1138-4EB 1138-4EB force-pushed the chore/commit-sha branch from be14b7d to 907d439 Aug 20, 2018

@1138-4EB 1138-4EB merged commit b1eb907 into master Aug 20, 2018

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@1138-4EB 1138-4EB deleted the chore/commit-sha branch Aug 20, 2018

hacdias pushed a commit that referenced this pull request May 11, 2019

chore: use commit SHA as version if not release (#505)
Former-commit-id: f94f65a805178a47be814226c69125f2c35b995e [formerly f87abdedd1a0b0a4187d11e6311a1fc5d95b9368] [formerly f0a8303535fdfa4bcb348c21e8576c32908255ed [formerly b1eb907]]
Former-commit-id: 31edb3a4cb01d8a091549d3b7a4dcc572b64baa8 [formerly 6b2abc348d488a7066812072a887df19ac70c720]
Former-commit-id: d7fbb8e61646a9fdc55699b0d016d8c13e676dcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.