This repository was archived by the owner on Aug 31, 2026. It is now read-only.
Repository navigation
fix: Fix nil deref in config set command - #5641
Merged
Merged
Conversation
Currently if the user sets --auth.method without --auth.header, if defaultAuther isn't defined then there is a nil deref. Check for nil directly so we can give a helpeful error message instead.
Contributor
Author
|
To illustrate the issue: |
hacdias
reviewed
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the user sets --auth.method without --auth.header, if defaultAuther isn't defined then there is a nil deref.
Check for nil directly so we can give a helpeful error message instead.
Description
Additional Information
Checklist
Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
masterbranch.