fix: generate OpenCL source at compile time #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenCL kernel source could be generated at run-time, but with this change it makes it more similar to the CUDA version, where we need to compile the kernel at compile-time. This is to improve the symmetry between those features and should also simplify the code for future changes.
|
It's again one of those PRs which are easier to review with whitespace changes hidden. |
cryptonemo
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenCL kernel source could be generated at run-time, but with this
change it makes it more similar to the CUDA version, where we need to
compile the kernel at compile-time. This is to improve the symmetry
between those features and should also simplify the code for future
changes.