Skip to content

Ensure graphsync transport only closes complete channel once #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Ensure graphsync transport only closes complete channel once #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions transport/graphsync/graphsync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,9 +894,13 @@ func (c *dtChannel) open(ctx context.Context, chid datatransfer.ChannelID, dataS
// Set up a completed channel that will be closed when the request
// completes (or is cancelled)
completed := make(chan struct{})
var onCompleteOnce sync.Once
onComplete := func() {
log.Infow("closing the completion ch for data-transfer channel", "chid", chid)
close(completed)
// Ensure the channel is only closed once
onCompleteOnce.Do(func() {
log.Infow("closing the completion ch for data-transfer channel", "chid", chid)
close(completed)
})
}
c.completed = completed

Expand Down