Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a struct over global vars in default_syncer_test #2700

Merged
merged 5 commits into from May 23, 2019

Conversation

@mslipper
Copy link
Contributor

commented May 1, 2019

Closes #2116. All *Test methods initialize a struct that contains the syncer params, which is in turn passed to all the other initialization/require* methods. Let me know if there's an alternative approach you'd like me to implement.

@mslipper

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Hmm, quite a few conflicts - if this is generally the right track let me know and I'll fix them. Would prefer to know the solution is OK before resolving.

@mslipper mslipper changed the title Display error when address is not a miner address Use a struct over global vars in default_syncer_test May 2, 2019

@frrist frrist requested a review from ZenGround0 May 2, 2019

@ZenGround0

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@mslipper this is definitely the right approach and generally great. As you've probably already seen the conflicts are most likely all related to our new usage pattern around the require and assert packages introduced in PR #2657. These should be mostly orthogonal and hopefully make the rebase process simple (though surely tedious).

@mslipper

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Excellent. I'll resolve the conflicts shortly.

@mslipper mslipper force-pushed the issue-2116 branch 2 times, most recently from 57ab497 to 2ce5cbb May 2, 2019

@ZenGround0
Copy link
Contributor

left a comment

This is great, thank you for cleaning up this mess

chain/default_store_test.go Outdated Show resolved Hide resolved

@mslipper mslipper force-pushed the issue-2116 branch from 2ce5cbb to 0870113 May 22, 2019

@ZenGround0 ZenGround0 requested a review from frrist May 22, 2019

@frrist
frrist approved these changes May 22, 2019
Copy link
Contributor

left a comment

Once the flags are added back, LGTM

chain/default_store_test.go Outdated Show resolved Hide resolved
@shannonwells
Copy link
Contributor

left a comment

once @frrist 's comments are addressed, gtg... thanks for taking on this tedious task. so much better now

chain/default_syncer_test.go Show resolved Hide resolved

@mslipper mslipper force-pushed the issue-2116 branch from 3463336 to ebda4e3 May 22, 2019

mslipper added 2 commits May 22, 2019

@ZenGround0 ZenGround0 merged commit e1985e8 into master May 23, 2019

5 checks passed

ci/circleci: build_linux-1 Your tests passed on CircleCI!
Details
ci/circleci: deps_linux Your tests passed on CircleCI!
Details
ci/circleci: functional_test_linux-1 Your tests passed on CircleCI!
Details
ci/circleci: integration_test_linux Your tests passed on CircleCI!
Details
ci/circleci: unit_test_linux Your tests passed on CircleCI!
Details
deaswang added a commit to filcloud/go-filecoin that referenced this pull request May 24, 2019
Use a struct over global vars in default_syncer_test (filecoin-projec…
…t#2700)

* Use a struct over global vars in default_syncer_test

Closes filecoin-project#2116.

* Remove bad unit test flags

* Add UnitTest flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.