Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadd docker support #745
add docker support #745
Conversation
This comment has been minimized.
This comment has been minimized.
|
Gonna ask @Kubuxu to do the review here, i'm not good at dockerfiles |
This comment has been minimized.
This comment has been minimized.
|
In case it helps @travisperson shared this Docker scripts gist. They've been edited though and not tested after edit so just pasting here for comparison. This one doesn't expose port 5678. This one is also working for me: https://github.com/mateodelnorte/filecoin-lotus-docker |
This comment has been minimized.
This comment has been minimized.
|
Thanks @eshon! Thats good context to have. I'm tagging @travisperson for review now |
|
SGWM but I'm not docker expert. |
|
I think this looks fine |
This comment has been minimized.
This comment has been minimized.
|
Note that if people have an earlier install they might have docker cache problems so some instructions running clean versions would be great as comments @ldoublewood |
This comment has been minimized.
This comment has been minimized.
|
@eshon Would you please elaborate what kind of "docker cache problem" will happen? |
This comment has been minimized.
This comment has been minimized.
|
@ldoublewood I think if you don't clear your cache it may not pull latest from master but from a saved copy in your cache so may want to run with |
This comment has been minimized.
This comment has been minimized.
|
@eshon should we add anything to the docs about this? I think we can merge this now in any case |
This comment has been minimized.
This comment has been minimized.
|
For now, you guys could create a @travisperson could use Each community contribution should have a separate descriptive folder of its purpose. For example:
" TLDR; There are different Docker and Docker Compose scripts for different use cases. Use Cases:
Nice-to-have:
The dockers in go-filecoin's However it'd be nice to collect Dockers for all use cases somewhere for the community that's easy to find. Option 1) Community dockers in a new Docker directory in the lotus repo - Easy for community members to find. Great examples of the nuances of running nodes. Option 2) filecoin-shipyard/lotus-dockers or filecoin-project/dockers - Less visibility, far from node implementation but in tune with go-filecoin's tradition that repo Dockers are for network infra so just references and actively maintained. TODO: |
This comment has been minimized.
This comment has been minimized.
|
A quick run of these Dockerfile seemed to have non-growing volumes. Taking a look inside the container |
This comment has been minimized.
This comment has been minimized.
|
Running with Maybe some anyone can further check if these facts are correct :) |
This comment has been minimized.
This comment has been minimized.
|
Gonna merge this now, lots of people have been asking for it. Its probably not perfect yet, but we do accept PRs :) |
9da4296
into
filecoin-project:master
ldoublewood commentedDec 5, 2019
This PR can close issue: #594