Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FVM: Use MaxInt64 for Implicit Message gas limits #9037

Merged
merged 1 commit into from Jul 15, 2022

Conversation

arajasek
Copy link
Contributor

Related Issues

We never want these to run out of gas.

Proposed Changes

So use the biggest possible number.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner July 14, 2022 21:41
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #9037 (7cd0ce4) into master (d4cdd82) will decrease coverage by 5.61%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9037      +/-   ##
==========================================
- Coverage   41.07%   35.45%   -5.62%     
==========================================
  Files         707      703       -4     
  Lines       78884    78661     -223     
==========================================
- Hits        32400    27893    -4507     
- Misses      40983    45702    +4719     
+ Partials     5501     5066     -435     
Impacted Files Coverage Δ
chain/vm/fvm.go 29.82% <100.00%> (+0.20%) ⬆️
chain/events/state/mock/state.go 0.00% <0.00%> (-100.00%) ⬇️
blockstore/badger/blockstore_test_suite.go 0.00% <0.00%> (-96.52%) ⬇️
tools/stats/headbuffer/head_buffer.go 0.00% <0.00%> (-90.00%) ⬇️
blockstore/splitstore/coldset.go 0.00% <0.00%> (-82.00%) ⬇️
chain/events/state/mock/api.go 0.00% <0.00%> (-80.00%) ⬇️
blockstore/splitstore/markset.go 0.00% <0.00%> (-75.00%) ⬇️
blockstore/splitstore/visitor.go 0.00% <0.00%> (-75.00%) ⬇️
journal/types.go 13.33% <0.00%> (-73.34%) ⬇️
lib/stati/covar.go 0.00% <0.00%> (-73.22%) ⬇️
... and 149 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants