Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor: remove NewestNetworkVersion #9351

Merged
merged 2 commits into from Sep 21, 2022

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Sep 21, 2022

Related Issues

This field has always been terrible (see TODO above it), and is potentially confusing to users (see #9319 (comment)).

Proposed Changes

Remove its only usage in source code, which is in the messagepool -- just query for the NetworkVersion when needed. If we have concerns that this is slow, we could just set it once at startup, and use that -- it is very rare for this to matter (hasn't mattered since nv7).

Rename remaining usages to TestNetworkVersion.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@arajasek arajasek requested a review from a team as a code owner September 21, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants