R1: Panics in actor space

[raulk]

[raulk]

This concern is no longer relevant as actor code now executes inside the Wasm sandbox. Any eventual panics inside actor code percolate as a Wasm trap, and would be handled by the From<Trap> implementation for Abort:

ref-fvm/fvm/src/syscalls/error.rs

Lines 51 to 54 in e5cf2e0

	// Actor panic/wasm error.
	if let Some(code) = t.trap_code() {
	return Abort::Exit(ExitCode::SysErrActorPanic, code.to_string());
	}

That implementation checks if the trap_code is informed. A manual Rust panic translates to an unreachable Wasm instruction. The trap_code value would be TrapCode::UnreachableCodeReached (needs verification). Thus we would raise an Abort with exit code SysErrActorPanic.

The conversion is triggered by the question mark operator here:

ref-fvm/fvm/src/call_manager/default.rs

Line 317 in 918e92e

let return_block_id = invoke.call(&mut store, (param_id,))?;

The exit code is then handled and returned here:

ref-fvm/fvm/src/call_manager/default.rs

Line 349 in 918e92e

(code, message, Ok(InvocationResult::Failure(code)))