Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage-proofs): zizag, drgporep and por abstract over the hasher in circuits #543

Merged
merged 7 commits into from Mar 19, 2019

Conversation

@dignifiedquire
Copy link
Member

commented Mar 12, 2019

Basic tests are passing. Needs some more checks

  • make por and drgporep circuits abstract over the hasher
  • implement blake2s hasher using blake2s_simd

Ref #531

@dignifiedquire dignifiedquire requested review from porcuquine and laser as code owners Mar 12, 2019

@dignifiedquire dignifiedquire force-pushed the blake2s branch 2 times, most recently from 0971a3f to 45c9f3d Mar 12, 2019

@dignifiedquire

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

@porcuquine this adds the hasher to the parameter identifiers, so I am guessing we have to change parameters versions again?

@porcuquine

This comment has been minimized.

Copy link
Collaborator

commented Mar 13, 2019

Hmmm, if it only changes the set of parameters generated but doesn't change the circuit/parameters for a given identifier, we don't need to bump the version. (The version is needed so we don't find old parameters by the name with which we request new ones.)

But we will need to generate and publish the parameter again. When doing that, remember to clear your cache first, so we don't keep stale parameters around in parameters.json.

(It's possible I'm seeing something wrong, so if this sounds mistaken, please flag.)

@dignifiedquire dignifiedquire force-pushed the blake2s branch 2 times, most recently from a597101 to e7bfd1d Mar 13, 2019

@dignifiedquire dignifiedquire changed the title feat: make por abstract over the hasher feat(storage-proofs): zizag, drgporep and por abstract over the hasher in circuits Mar 13, 2019

@dignifiedquire

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

This is ready to go from my side. Note this will need new params published again, as now the hasher is part of the cache identifier

@porcuquine

This comment has been minimized.

Copy link
Collaborator

commented Mar 13, 2019

Can you include the param publishing in this PR? That would be the best way to do it and should be our policy. Include a comment here stating that you pinned and verified.

@porcuquine

This comment has been minimized.

Copy link
Collaborator

commented Mar 13, 2019

We should see a diff to parameters.json in this branch as well (over-explaining because this is new process).

@porcuquine

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

Looking good, @dignifiedquire. Any chance of extending this to the merklepor example, so we can run that with --hasher blake2s?

@porcuquine
Copy link
Collaborator

left a comment

Nice.

@dignifiedquire dignifiedquire merged commit 248eff0 into master Mar 19, 2019

11 checks passed

ci/circleci: bench_nightly Your tests passed on CircleCI!
Details
ci/circleci: build_darwin_release Your tests passed on CircleCI!
Details
ci/circleci: build_linux_release Your tests passed on CircleCI!
Details
ci/circleci: cargo_fetch Your tests passed on CircleCI!
Details
ci/circleci: clippy Your tests passed on CircleCI!
Details
ci/circleci: ffi_regression Your tests passed on CircleCI!
Details
ci/circleci: rustfmt Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test_ignored_release Your tests passed on CircleCI!
Details
ci/circleci: test_nightly Your tests passed on CircleCI!
Details
ci/circleci: test_release Your tests passed on CircleCI!
Details

@dignifiedquire dignifiedquire deleted the blake2s branch Mar 19, 2019

@nicola nicola referenced this pull request Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.