Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Miner: Incorrect bounds on SubmitWindowedPoSt params.Deadline #753

Closed
wadealexc opened this issue Jul 21, 2020 · 0 comments · Fixed by #789
Closed

Miner: Incorrect bounds on SubmitWindowedPoSt params.Deadline #753

wadealexc opened this issue Jul 21, 2020 · 0 comments · Fixed by #789
Assignees
@Stebalien
Labels
bug Something isn't working P1 High priority, required for basic network functionality and growth

Comments

@wadealexc
Copy link

This check is incorrect:

specs-actors/actors/builtin/miner/miner_actor.go

Lines 252 to 254 in 84de6c6

if params.Deadline > WPoStPeriodDeadlines {
rt.Abortf(exitcode.ErrIllegalArgument, "invalid deadline %d of %d", params.Deadline, WPoStPeriodDeadlines)
}

Should be >=
@anorth anorth added bug Something isn't working P1 High priority, required for basic network functionality and growth labels Jul 23, 2020
@Stebalien Stebalien mentioned this issue Jul 24, 2020
Merged
@anorth anorth mentioned this issue Jul 24, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Stebalien Stebalien

Labels
bug Something isn't working P1 High priority, required for basic network functionality and growth
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deadline index check filecoin-project/specs-actors
3 participants
@Stebalien @anorth @wadealexc