Q module is actually q #1

Merged
merged 1 commit into from Feb 25, 2014

Conversation

Projects
None yet
2 participants
Contributor

ashishpuliyel commented Feb 25, 2014

Case sensitive platforms (linux) need the Q module to be required as
“require(‘q’)” not “require(‘Q’)” (because that's the name on npm - https://www.npmjs.org/package/q)

Heroku, for example, will fail

@ashishpuliyel ashishpuliyel Q module is actually q
Case sensitive platforms (linux) need the Q module to be required as
“require(‘q’)” not “require(‘Q’)”
5298c10
Owner

AnalogJ commented Feb 25, 2014

LGTM, thanks for the PR @ashishpuliyel

@AnalogJ AnalogJ added a commit that referenced this pull request Feb 25, 2014

@AnalogJ AnalogJ Merge pull request #1 from ashishpuliyel/master
Q module is actually q
9319b64

@AnalogJ AnalogJ merged commit 9319b64 into filefog:master Feb 25, 2014

Contributor

ashishpuliyel commented Feb 25, 2014

Sorry - I didn't increment the version number in package.json - which you need to do to ensure the changes will go out on npm?

Owner

AnalogJ commented Feb 25, 2014

No worries. I've updated the package.json and published to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment