Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for fs.exists() when it follows symbolic link and can't find directory #475

Closed
iblacker opened this issue Sep 24, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@iblacker
Copy link
Contributor

commented Sep 24, 2018

I have noticed the test fs.exists() doesn't account for the case when the the path is a symbolic link and there is no resulting directory.

I would like to add the test for that. What do you think?

Alternatively I could also create a test for fs.rmdir() to test when the target is a (hard) link, which the test should fail.

@humphd

@humphd

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2018

OK, go for it @iblacker

@humphd humphd closed this in #519 Oct 9, 2018

humphd added a commit that referenced this issue Oct 9, 2018

Fix issue #475 - Add test for fs.exits() when resulting path of a sym…
…bolic link is not found (#519)

* add test for exits when resulting path of a symbolic link is not found

* fixed style nit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.