New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing eslint does not always fail the build #482

Closed
0xazure opened this Issue Sep 24, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@0xazure
Contributor

0xazure commented Sep 24, 2018

In reviewing #478, I ran into a failure in eslint when running the PR locally. The CI build for the PR succeeded, however viewing the build details shows the same lint error but exited 0.

I'm also not sure why the build exited 0 when locally npm test on the same PR exits 1.

@humphd is this intended?

@humphd

This comment has been minimized.

Contributor

humphd commented Sep 24, 2018

I reran that build, and it failed as expected. I guess this is an intermittent bug in Travis? Very odd

https://travis-ci.org/filerjs/filer/builds/432510814

@0xazure

This comment has been minimized.

Contributor

0xazure commented Sep 24, 2018

Definitely seems like an intermittent Travis issue. Closing for now since the issue wasn't repeatable on the same branch and is likely an infrastructure problem.

@0xazure 0xazure closed this Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment