Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting an existing mkdir callback test to use promises #491

Closed
yevseytsev opened this issue Sep 24, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@yevseytsev
Copy link
Contributor

commented Sep 24, 2018

No description provided.

@yevseytsev yevseytsev changed the title I want to write a test for mkdir. If '/' exists in the dir name, then it rejects you to create a dir I want to write a test for mkdir. Sep 24, 2018

@yevseytsev yevseytsev changed the title I want to write a test for mkdir. want to write a test for mkdir. If restricted symbols exist in the dir name, then it rejects you to create a dir Sep 24, 2018

@humphd

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2018

OK @yevseytsev, go for it. One tip when you're filling issues: use a shorter title, and then put the bulk of your info in the comment for the Issue. In your case, you could have done:

Title: Add test for mkdir with restricted symbols.
Body: I noticed that there isn't a test for the case that you call mkdir with a path that includes a restricted symbol. It should fail to create the illegal path name.

@yevseytsev

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2018

I have talked to you on Slack, and we decided that I will convert an existing mkdir callback test to use promises vs. current issue, since this isn't a real bug

@yevseytsev yevseytsev changed the title want to write a test for mkdir. If restricted symbols exist in the dir name, then it rejects you to create a dir Converting an existing mkdir callback test to use promises Sep 29, 2018

@humphd humphd closed this Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.